WIP: feat: Add contains_exactly filter#391
Open
sabard wants to merge 2 commits intographql-python:add-filtersfrom
Open
WIP: feat: Add contains_exactly filter#391sabard wants to merge 2 commits intographql-python:add-filtersfrom
sabard wants to merge 2 commits intographql-python:add-filtersfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## add-filters #391 +/- ##
===============================================
- Coverage 96.37% 93.13% -3.25%
===============================================
Files 9 10 +1
Lines 773 1296 +523
===============================================
+ Hits 745 1207 +462
- Misses 28 89 +61 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
contains_exactlyfilter implements relational division, essentially finding entities related to those specified exactly by a search criteria. That is, found entities should have no relations not specified by the search criteria.contains_exactlywas not working with async sqlalchemy 1.4 and was holding up #357, so it was removed. This PR adds back the feature.